linux-kernel - Re: [PATCH 13/19] arm64: dts: qcom: x1e80100: Fix ADSP memory base and length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d93c5bf-99eb-4248-bedb-2318c7505f13@linaro.org>
Date: Mon, 9 Dec 2024 11:52:25 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Johan Hovold <johan@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>, Abel Vesa
 <abel.vesa@...aro.org>, Sibi Sankar <quic_sibis@...cinc.com>,
 Luca Weiss <luca.weiss@...rphone.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH 13/19] arm64: dts: qcom: x1e80100: Fix ADSP memory base
 and length

On 06/12/2024 16:49, Johan Hovold wrote:
> On Fri, Dec 06, 2024 at 04:32:37PM +0100, Krzysztof Kozlowski wrote:
>> The address space in ADSP PAS (Peripheral Authentication Service)
>> remoteproc node should point to the QDSP PUB address space
>> (QDSP6...SS_PUB): 0x0680_0000 with length of 0x10000.
>>
>> 0x3000_0000, value used so far, is the main region of CDSP.  Downstream
>> DTS uses 0x0300_0000, which is oddly similar to 0x3000_0000, yet quite
>> different and points to unused area.
> 
> This looks like a copy-paste error since there is no downstream DTS for
> x1e80100.
> 
> And this paragraph is about the CDSP so probably does not belong in the
> commit message of the ADSP patches (e.g. sm8650).

Yeah, copy-paste. I'll drop it.

Best regards,
Krzysztof