linux-kernel - Re: [PATCH v2 6/6] mmc: sdhci-acpi: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52ac8bbc-49d1-4104-98e2-40bb69c23f09@intel.com>
Date: Mon, 9 Dec 2024 13:32:36 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Victor Shih <victor.shih@...esyslogic.com.tw>, linux-mmc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] mmc: sdhci-acpi: Don't use "proxy" headers

On 1/11/24 12:11, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use) principle.
> While at it, sort them alphabetically for better maintenance.

Not a fan of alphabetical order for include files.
In this case it makes it hard to see what actually
changed.

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/mmc/host/sdhci-acpi.c | 33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index c931f506c1b0..fcb69a509c1e 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -5,27 +5,30 @@
>   * Copyright (c) 2012, Intel Corporation.
>   */
>  
> +#include <linux/acpi.h>
>  #include <linux/bitfield.h>
> -#include <linux/init.h>
> -#include <linux/export.h>
> -#include <linux/module.h>
> +#include <linux/bitops.h>
> +#include <linux/compiler.h>
> +#include <linux/delay.h>
>  #include <linux/device.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/dmi.h>
> +#include <linux/err.h>
> +#include <linux/errno.h>
> +#include <linux/export.h>
> +#include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
> +#include <linux/ioport.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
>  #include <linux/pinctrl/pinconf-generic.h>
>  #include <linux/platform_device.h>
> -#include <linux/ioport.h>
> -#include <linux/io.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/compiler.h>
> -#include <linux/stddef.h>
> -#include <linux/bitops.h>
> -#include <linux/types.h>
> -#include <linux/err.h>
> -#include <linux/interrupt.h>
> -#include <linux/acpi.h>
>  #include <linux/pm.h>
>  #include <linux/pm_runtime.h>
> -#include <linux/delay.h>
> -#include <linux/dmi.h>
> +#include <linux/stddef.h>
> +#include <linux/types.h>
> +#include <linux/uuid.h>
>  
>  #include <linux/mmc/host.h>
>  #include <linux/mmc/pm.h>