linux-kernel - Re: [PATCH v7 12/14] arm64: dts: qcom: sdm845-starqltechn: add initial sound support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABTCjFD7ChwXEZYLqAro_rerNN490ZViZ=qRA6sx1dGWVW5SeA@mail.gmail.com>
Date: Mon, 9 Dec 2024 14:34:43 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: cros-qcom-dts-watchers@...omium.org, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v7 12/14] arm64: dts: qcom: sdm845-starqltechn: add
 initial sound support

чт, 5 дек. 2024 г. в 19:45, Konrad Dybcio <konrad.dybcio@....qualcomm.com>:
>
> On 4.12.2024 10:34 PM, Dzmitry Sankouski wrote:
> > Add support for sound (headphones and mics only)
> > Also redefine slpi reserved memory, because adsp_mem overlaps with
> > slpi_mem inherited from sdm845.dtsi.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> >
> > ---
>
> [...]
>
>
> > +     audio-routing = "RX_BIAS", "MCLK",
> > +                     "AMIC2", "MIC BIAS2",   /* Headset Mic */
> > +                     "AMIC3", "MIC BIAS2",   /* FMLeft Tx */
> > +                     "AMIC4", "MIC BIAS2",   /* FMRight Tx */
>
> FM - FM radio, or "Front Mic" / earpiece?

FM radio. I'll fix the comment to avoid ambiguity.

>
> > +                     "DMIC0", "MCLK",        /* Bottom Mic */
> > +                     "DMIC0", "MIC BIAS1",
> > +                     "DMIC2", "MCLK",        /* Top Mic */
>
> Looking at some pictures, I'm guessing these two are the little holes
> in the top/bottom edges of the device?

Yes.

-- 
Best regards and thanks for review,
Dzmitry