linux-kernel - Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1g_nFhYXrBxHtrb@hovoldconsulting.com>
Date: Tue, 10 Dec 2024 14:18:20 +0100
From: Johan Hovold <johan@...nel.org>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sibi Sankar <quic_sibis@...cinc.com>, Marc Zyngier <maz@...nel.org>,
	Xilin Wu <wuxilin123@...il.com>, Abel Vesa <abel.vesa@...aro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Aleksandrs Vinarskis <alex.vinarskis@...il.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
> 
> Since most X1E device trees just mirror the power supplies from the
> x1e80100-crd device tree, this series fixes up all the X1E boards with
> the same change.

Nice find! I've confirmed that this matches both the CRD and T14s
schematics.

> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>

> Stephan Gerhold (8):
>       arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies

nit: We've been using the shorter "x1e78100-t14s" prefix for this one so
far. This may apply to some of the others as well.

>       arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>

Johan