linux-kernel - Re: [PATCH v4 07/13] wifi: ath12k: add support for fixed QMI firmware memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d86b600-a7b1-4f7f-87ba-c167ec8c0405@kernel.org>
Date: Tue, 10 Dec 2024 15:43:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>, ath12k@...ts.infradead.org
Cc: linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 07/13] wifi: ath12k: add support for fixed QMI firmware
 memory

On 10/12/2024 08:41, Raj Kumar Bhagat wrote:
> +		case CALDB_MEM_REGION_TYPE:
> +			/* Cold boot calibration is not enabled in Ath12k. Hence,
> +			 * assign paddr = 0.
> +			 * Once cold boot calibration is enabled add support to
> +			 * assign reserved memory from DT.
> +			 */
> +			ab->qmi.target_mem[idx].paddr = 0;
> +			ab->qmi.target_mem[idx].v.ioaddr = NULL;
> +			ab->qmi.target_mem[idx].size = ab->qmi.target_mem[i].size;
> +			ab->qmi.target_mem[idx].type = ab->qmi.target_mem[i].type;
> +			idx++;
> +			break;
> +		case M3_DUMP_REGION_TYPE:
> +			dev_node = of_find_node_by_name(NULL, "m3_dump");

NAK

That's neither correct name nor documented in the bindings. You created
now undocumented ABI. Even with incorrect name. :/


> +			if (!dev_node || of_address_to_resource(dev_node, 0, &m3_res)) {
> +				ath12k_err(ab, "m3_dump not defined in device-tree\n");
> +				ret = -EINVAL;
> +				goto out;
> +			}
> +


Best regards,
Krzysztof