linux-kernel - Re: [PATCH net-next v14 22/22] testing/selftests: add test tool and scripts for ovpn module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210164715.GB6554@kernel.org>
Date: Tue, 10 Dec 2024 16:47:15 +0000
From: Simon Horman <horms@...nel.org>
To: Antonio Quartulli <antonio@...nvpn.net>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Donald Hunter <donald.hunter@...il.com>,
	Shuah Khan <shuah@...nel.org>, sd@...asysnail.net,
	ryazanov.s.a@...il.com, Andrew Lunn <andrew+netdev@...n.ch>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net-next v14 22/22] testing/selftests: add test tool and
 scripts for ovpn module

On Mon, Dec 09, 2024 at 09:53:31AM +0100, Antonio Quartulli wrote:
> The ovpn-cli tool can be compiled and used as selftest for the ovpn
> kernel module.
> 
> [NOTE: it depends on libmedtls for decoding base64-encoded keys]
> 
> ovpn-cli implements the netlink and RTNL APIs and can thus be integrated
> in any script for more automated testing.
> 
> Along with the tool, 4 scripts are provided that perform basic
> functionality tests by means of network namespaces.
> These scripts take part to the kselftest automation.
> 
> The output of the scripts, which will appear in the kselftest
> reports, is a list of steps performed by the scripts plus some
> output coming from the execution of `ping`, `iperf` and `ovpn-cli`
> itself.
> In general it is useful only in case of failure, in order to
> understand which step has failed and why.
> 
> Cc: linux-kselftest@...r.kernel.org
> Signed-off-by: Antonio Quartulli <antonio@...nvpn.net>
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

...

> +/**
> + * Helper function used to easily add attributes to a rtnl message
> + */

Hi Antonio,

This comment starts with a '/**' but is otherwise not formatted as
a Kernel doc. Probably it is best to simply start the comment with '/*'.

Likewise elsewhere in this patch.

Flagged by ./scripts/kernel-doc -none

> +static int ovpn_addattr(struct nlmsghdr *n, int maxlen, int type,
> +			const void *data, int alen)

...