linux-kernel - Re: [PATCH v2] ima: instantiate the bprm_creds_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <983114dbf101b0df7d61a31af002783d06fc963d.camel@linux.ibm.com>
Date: Tue, 10 Dec 2024 11:47:54 -0500
From: Mimi Zohar <zohar@...ux.ibm.com>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Paul Moore <paul@...l-moore.com>, linux-integrity@...r.kernel.org,
        roberto.sassu@...wei.com, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jeff Xu <jeffxu@...omium.org>,
        Kees Cook
	 <kees@...nel.org>, audit@...r.kernel.org
Subject: Re: [PATCH v2] ima: instantiate the bprm_creds_for_exec() hook

On Tue, 2024-12-10 at 17:34 +0100, Mickaël Salaün wrote:
> > > > +++ b/include/uapi/linux/audit.h
> > > > @@ -161,6 +161,7 @@
> > > >   #define AUDIT_INTEGRITY_RULE	    1805 /* policy rule */
> > > >   #define AUDIT_INTEGRITY_EVM_XATTR   1806 /* New EVM-covered xattr */
> > > >   #define AUDIT_INTEGRITY_POLICY_RULE 1807 /* IMA policy rules */
> > > > +#define AUDIT_INTEGRITY_DATA_CHECK  1808 /* Userspace enforced data integrity */
> > > 
> > > I worry that "DATA_CHECK" is a bit vague, should we change the name so
> > > that there is some hint of either userspace enforcement or
> > > AT_EXECVE_CHECK?
> > > 
> > > What about AUDIT_INTEGRITY_DATA_USER?
> > 
> > The emphasis should be on userspace - AUDIT_INTEGRITY_USERSPACE.
> 
> Looks good, I'll send a new patch series with this change, following
> https://lore.kernel.org/all/20241205160925.230119-9-mic@digikod.net/

Sound good!  Thank you.

Mimi