linux-kernel - Re: [PATCH v3 0/5] perf stat: Fix trailing comma when there is no metric unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1iLqNmDyNH7fDpa@x1>
Date: Tue, 10 Dec 2024 15:42:48 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>, James Clark <james.clark@...aro.org>
Cc: linux-perf-users@...r.kernel.org, namhyung@...nel.org,
	tim.c.chen@...ux.intel.com, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] perf stat: Fix trailing comma when there is no
 metric unit

On Tue, Nov 12, 2024 at 04:00:40PM +0000, James Clark wrote:
> The first commit is failing on Arm and I think the fix should stop more
> trailing comma issues which keep happening.
> 
> The second one I just noticed when looking at it. I don't feel strongly
> about it so not sure if we should do it or not, but seems like the empty
> metric-units exclusion from the JSON should be consistent if we're going
> to have it at all.
> 
> Changes since v2:
>   * Do more documentation and tidyups around struct outstate

Ian, have you had the chance of going over this series?

- Arnaldo
 
> Changes since v1:
>   * Don't skip printing when the metric-unit string is empty but pass
>     NULL instead of an empty string.
> 
> James Clark (5):
>   perf stat: Fix trailing comma when there is no metric unit
>   perf stat: Also hide metric-units from JSON when event didn't run
>   perf stat: Remove empty new_line_metric function
>   perf stat: Document and simplify interval timestamps
>   perf stat: Document and clarify outstate members
> 
>  tools/perf/arch/x86/util/iostat.c             |   4 +
>  .../tests/shell/lib/perf_json_output_lint.py  |  14 +-
>  tools/perf/util/stat-display.c                | 242 ++++++++++--------
>  tools/perf/util/stat-shadow.c                 |   5 +-
>  4 files changed, 147 insertions(+), 118 deletions(-)
> 
> -- 
> 2.34.1