linux-kernel - Re: [PATCH 0/4] Remove problematic include in <asm/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bec0778-3b70-41bb-b1b3-a7559cf88dd4@redhat.com>
Date: Tue, 10 Dec 2024 20:57:25 +0100
From: David Hildenbrand <david@...hat.com>
To: Kevin Brodsky <kevin.brodsky@....com>, x86@...nel.org
Cc: linux-kernel@...r.kernel.org, bp@...en8.de, dan.j.williams@...el.com,
 dave.hansen@...ux.intel.com, jane.chu@...cle.com, osalvador@...e.de,
 tglx@...utronix.de
Subject: Re: [PATCH 0/4] Remove problematic include in <asm/set_memory.h>

On 10.12.24 19:46, Kevin Brodsky wrote:
> The need for this series arose from a completely unrelated series [1].
> Long story short, that series causes <linux/mm.h> to include
> <linux/set_memory.h>, which doesn't feel too unreasonable.
> 
> That works fine on arm64 and probably most other architectures, but not
> on x86 [2]: <asm/set_memory.h> itself includes <linux/mm.h>, creating a
> circular dependency.
> 
> set_memory.h doesn't really need <linux/mm.h>, so removing that include
> seems like the right thing to do. That turned out to be a little more
> involved than expected, hence this series:
> 
> * Patch 1-2 ensure that code doesn't rely on <asm/set_memory.h>
>    including <linux/mm.h>. The errors that these patches fix are included
>    at the end of this email.
> 
> * Patch 3 removes an unused function whose declaration relied on
>    <linux/mm.h> being included.
>   
> * Patch 4 actually remove the include.
> 
> I've build-tested this series with x86_64_defconfig and allyesconfig.
> 
> - Kevin
> 
> [1] https://lore.kernel.org/linux-hardening/20241206101110.1646108-1-kevin.brodsky@arm.com/
> [2] https://lore.kernel.org/oe-kbuild-all/202412062006.C23V9ESs-lkp@intel.com/
> 
> Cc: bp@...en8.de
> Cc: dan.j.williams@...el.com
> Cc: dave.hansen@...ux.intel.com
> Cc: david@...hat.com
> Cc: jane.chu@...cle.com
> Cc: osalvador@...e.de
> Cc: tglx@...utronix.de
> ---

LGTM

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb