linux-kernel - Re: [PATCH 1/4] x86/smp: Explicitly include <linux/thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210213626.GNZ1i0WsS0XCoaoEY1@fat_crate.local>
Date: Tue, 10 Dec 2024 22:36:26 +0100
From: Borislav Petkov <bp@...en8.de>
To: Kevin Brodsky <kevin.brodsky@....com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, dan.j.williams@...el.com,
	dave.hansen@...ux.intel.com, david@...hat.com, jane.chu@...cle.com,
	osalvador@...e.de, tglx@...utronix.de
Subject: Re: [PATCH 1/4] x86/smp: Explicitly include <linux/thread_info.h>

On Tue, Dec 10, 2024 at 06:46:07PM +0000, Kevin Brodsky wrote:
> diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
> index ca073f40698f..88e72b414bfa 100644
> --- a/arch/x86/include/asm/smp.h
> +++ b/arch/x86/include/asm/smp.h
> @@ -6,7 +6,7 @@
>  
>  #include <asm/cpumask.h>
>  #include <asm/current.h>
> -#include <asm/thread_info.h>
> +#include <linux/thread_info.h>

linux/ namespace headers come before asm/ ones, I'd say.

But, more importantly, why is this 4 patches instead of 2:

1. Remove unused __set_memory_prot
2. Fixup include hell

?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette