linux-kernel - Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <364aaf7c-cdc4-4e57-bb4c-f62e57c23279@csgroup.eu>
Date: Tue, 10 Dec 2024 21:01:53 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Martin Kelly <martin.kelly@...wdstrike.com>,
 "masahiroy@...nel.org" <masahiroy@...nel.org>,
 "ojeda@...nel.org" <ojeda@...nel.org>,
 "jpoimboe@...nel.org" <jpoimboe@...nel.org>,
 "pasha.tatashin@...een.com" <pasha.tatashin@...een.com>,
 "mhiramat@...nel.org" <mhiramat@...nel.org>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "james.clark@....com" <james.clark@....com>,
 "mpe@...erman.id.au" <mpe@...erman.id.au>,
 "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
 "mingo@...hat.com" <mingo@...hat.com>,
 "rostedt@...dmis.org" <rostedt@...dmis.org>,
 "nathan@...nel.org" <nathan@...nel.org>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>,
 "nicolas@...sle.eu" <nicolas@...sle.eu>,
 "surenb@...gle.com" <surenb@...gle.com>,
 "npiggin@...il.com" <npiggin@...il.com>,
 "mark.rutland@....com" <mark.rutland@....com>, "hpa@...or.com"
 <hpa@...or.com>, "peterz@...radead.org" <peterz@...radead.org>,
 "zhengyejian@...weicloud.com" <zhengyejian@...weicloud.com>,
 "naveen.n.rao@...ux.ibm.com" <naveen.n.rao@...ux.ibm.com>,
 "bp@...en8.de" <bp@...en8.de>,
 "kent.overstreet@...ux.dev" <kent.overstreet@...ux.dev>,
 "mcgrof@...nel.org" <mcgrof@...nel.org>
Cc: Amit Dang <amit.dang@...wdstrike.com>,
 "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
 "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
 "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
 "linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix
 weak function issue

Hi,

Le 10/12/2024 à 20:15, Martin Kelly a écrit :
> [Vous ne recevez pas souvent de courriers de martin.kelly@...wdstrike.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Tue, 2024-07-23 at 14:32 +0800, Zheng Yejian wrote:
>> Background of this patch set can be found in v1:
>>
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20240613133711.2867745-1-zhengyejian1%40huawei.com%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cbc4f27151ef04b74fba608dd194f0034%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638694550404456289%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=a5XFKy9qxVrM5yXuvJuilJ%2FsUxU4j326MOmEz7dBViY%3D&reserved=0
>>
>>
>> Here add a reproduction to show the impact to livepatch:
>> 1. Add following hack to make livepatch-sample.ko do patch on
>> do_one_initcall()
>>     which has an overriden weak function behind in vmlinux, then print
>> the
>>     actually used __fentry__ location:
>>
> 
> Hi all, what is the status of this patch series? I'd really like to see
> it or some other fix to this issue merged. The underlying bug is a
> significant one that can cause ftrace/livepatch/BPF fentry to fail
> silently. I've noticed this bug in another context[1] and realized
> they're the same issue.
> 
> I'm happy to help with this patch series to address any issues as
> needed.

As far as I can see there are problems on build with patch 1, see 
https://patchwork.kernel.org/project/linux-modules/patch/20240723063258.2240610-2-zhengyejian@huaweicloud.com/

> 
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fbpf%2F7136605d24de9b1fc62d02a355ef11c950a94153.camel%40crowdstrike.com%2FT%2F%23mb7e6f84ac90fa78989e9e2c3cd8d29f65a78845b&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cbc4f27151ef04b74fba608dd194f0034%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638694550404477455%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C80000%7C%7C%7C&sdata=v9qPnj%2FDDWAuSdB6dP19nyxUWijxveymI6mQb63KxbY%3D&reserved=0

Christophe