linux-kernel - Re: Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d25741d8a6f88d5a6c219fb53e8aa0bcc1fea982.camel@crowdstrike.com>
Date: Tue, 10 Dec 2024 20:49:51 +0000
From: Martin Kelly <martin.kelly@...wdstrike.com>
To: "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "ojeda@...nel.org"
	<ojeda@...nel.org>,
        "jpoimboe@...nel.org" <jpoimboe@...nel.org>,
        "pasha.tatashin@...een.com" <pasha.tatashin@...een.com>,
        "mhiramat@...nel.org" <mhiramat@...nel.org>,
        "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>,
        "james.clark@....com" <james.clark@....com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "nathan@...nel.org"
	<nathan@...nel.org>,
        "christophe.leroy@...roup.eu"
	<christophe.leroy@...roup.eu>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "nicolas@...sle.eu" <nicolas@...sle.eu>,
        "mathieu.desnoyers@...icios.com"
	<mathieu.desnoyers@...icios.com>,
        "npiggin@...il.com" <npiggin@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "hpa@...or.com"
	<hpa@...or.com>,
        "surenb@...gle.com" <surenb@...gle.com>,
        "zhengyejian@...weicloud.com" <zhengyejian@...weicloud.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "naveen.n.rao@...ux.ibm.com"
	<naveen.n.rao@...ux.ibm.com>,
        "kent.overstreet@...ux.dev"
	<kent.overstreet@...ux.dev>,
        "bp@...en8.de" <bp@...en8.de>, "mcgrof@...nel.org" <mcgrof@...nel.org>
CC: Amit Dang <amit.dang@...wdstrike.com>,
        "linux-modules@...r.kernel.org"
	<linux-modules@...r.kernel.org>,
        "linux-kbuild@...r.kernel.org"
	<linux-kbuild@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and
 fix weak function issue

On Tue, 2024-12-10 at 21:01 +0100, Christophe Leroy wrote:
> > 
> > Hi all, what is the status of this patch series? I'd really like to
> > see
> > it or some other fix to this issue merged. The underlying bug is a
> > significant one that can cause ftrace/livepatch/BPF fentry to fail
> > silently. I've noticed this bug in another context[1] and realized
> > they're the same issue.
> > 
> > I'm happy to help with this patch series to address any issues as
> > needed.
> 
> As far as I can see there are problems on build with patch 1, see 
> https://patchwork.kernel.org/project/linux-modules/patch/20240723063258.2240610-2-zhengyejian@huaweicloud.com/
>  
> 
> 

Yeah, I see those. Additionally, this patch no longer applies cleanly
to current master, though fixing it up to do so is pretty easy. Having
done that, this series appears to resolve the issues I saw in the other
linked thread.

Zheng, do you plan to send a v3? I'd be happy to help out with this
patch series if you'd like, as I'm hoping to get this issue resolved
(though I am not an ftrace expert).