linux-kernel - Re: [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMcHhXpvwR50GCkTvtkmWW4mvV5o9vbMvrvqLiEkJpKDHP_REA@mail.gmail.com>
Date: Tue, 10 Dec 2024 21:44:33 +0100
From: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Sibi Sankar <quic_sibis@...cinc.com>, Marc Zyngier <maz@...nel.org>, Xilin Wu <wuxilin123@...il.com>, 
	Abel Vesa <abel.vesa@...aro.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Johan Hovold <johan@...nel.org>, "Tudor, Laurentiu" <Laurentiu.Tudor1@...l.com>
Subject: Re: [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB
 QMP PHY supplies

On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold
<stephan.gerhold@...aro.org> wrote:
>
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
>
> Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies from
> the x1e80100-crd device tree, assume that the fix also applies here.

Though I can't verify schematics (perhaps Laurentiu can?), can confirm
USBs still work as expected with this change.

Tested-by: Aleksandrs Vinarskis <alex.vinarskis@...il.com>

>
> Cc: stable@...r.kernel.org
> Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a43adec291a31f9beed 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy {
>  };
>
>  &usb_1_ss0_qmpphy {
> -       vdda-phy-supply = <&vreg_l3e_1p2>;
> +       vdda-phy-supply = <&vreg_l2j_1p2>;
>         vdda-pll-supply = <&vreg_l1j_0p9>;
>
>         status = "okay";
> @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy {
>  };
>
>  &usb_1_ss1_qmpphy {
> -       vdda-phy-supply = <&vreg_l3e_1p2>;
> +       vdda-phy-supply = <&vreg_l2j_1p2>;
>         vdda-pll-supply = <&vreg_l2d_0p9>;
>
>         status = "okay";
>
> --
> 2.47.0
>