linux-kernel - Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1hgW-_pqqCpIwH0@hovoldconsulting.com>
Date: Tue, 10 Dec 2024 16:38:03 +0100
From: Johan Hovold <johan@...nel.org>
To: Marc Zyngier <maz@...nel.org>, Sibi Sankar <quic_sibis@...cinc.com>
Cc: Stephan Gerhold <stephan.gerhold@...aro.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Xilin Wu <wuxilin123@...il.com>,
	Abel Vesa <abel.vesa@...aro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Aleksandrs Vinarskis <alex.vinarskis@...il.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote:
> On Tue, 10 Dec 2024 13:18:20 +0000,
> Johan Hovold <johan@...nel.org> wrote:
> > 
> > On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> > > are actually powered by &vreg_l2j_1p2.
> > > 
> > > Since most X1E device trees just mirror the power supplies from the
> > > x1e80100-crd device tree, this series fixes up all the X1E boards with
> > > the same change.
> > 
> > Nice find! I've confirmed that this matches both the CRD and T14s
> > schematics.
> 
> Can someone with access to the schematics confirm that the devkit
> indeed has the same supplies?

Sibi, can you confirm our assumption that these definitions were copied
from the CRD devicetree and need to be fixed like this also for the
devkit?

Johan