linux-kernel - Re: [PATCH v4 2/2] dt-bindings: input: Add Nuvoton MA35D1 keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <274c7ba7-dd7a-4981-95a8-38ed953a7dbc@gmail.com>
Date: Tue, 10 Dec 2024 13:23:39 +0800
From: Ming-Jen Chen <mjchen0829@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 sudeep.holla@....com, arnd@...db.de, peng.fan@....com, conor+dt@...nel.org,
 krzk+dt@...nel.org, robh@...nel.org, dmitry.torokhov@...il.com
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Add Nuvoton MA35D1 keypad



On 2024/12/4 下午 03:49, Krzysztof Kozlowski wrote:
> On Wed, Dec 04, 2024 at 02:10:14AM +0000, Ming-Jen Chen wrote:
>> Add YAML bindings for MA35D1 SoC keypad.
>>
>> Signed-off-by: Ming-Jen Chen <mjchen0829@...il.com>
> 
> 
> Repeating same comment third or fourth time is a waste of my time.
> 
> NAK.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Best regards,
> Krzysztof
> 

I will carefully review the v3 discussion thread to ensure that all
feedback is properly implemented. Once I’ve addressed the issues, I’d
like to confirm the next steps with you:

1. Should I drop v4 entirely and submit a revised patch as v5?
2. Alternatively, would you prefer me to resend v4 with the necessary
corrections?

Please let me know your preference so I can proceed accordingly and
ensure a smoother review process.

Thank you again for your guidance and understanding.

Best regards,
Ming-Jen Chen