linux-kernel - Re: [PATCH v6 6/7] pinctrl: s32cc: implement GPIO functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <384bdbaf-15f1-4cad-8f77-371ccb67d952@web.de>
Date: Wed, 11 Dec 2024 18:02:46 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Andrei Stefanescu <andrei.stefanescu@....nxp.com>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, s32@....com,
 Bartosz Golaszewski <brgl@...ev.pl>, Chester Lin <chester62515@...il.com>,
 Conor Dooley <conor+dt@...nel.org>, Dong Aisheng <aisheng.dong@....com>,
 Fabio Estevam <festevam@...il.com>,
 Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jacky Bai
 <ping.bai@....com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Larisa Grigore <larisa.grigore@....com>, Lee Jones <lee@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Matthias Brugger <mbrugger@...e.com>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
 Alberto Ruiz <aruizrui@...hat.com>, Christophe Lizzi <clizzi@...hat.com>,
 Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH v6 6/7] pinctrl: s32cc: implement GPIO functionality

…
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
…
> +static void s32_gpio_free(struct gpio_chip *gc, unsigned int gpio)
> +{
…
> +	spin_lock_irqsave(&ipctl->gpio_configs_lock, flags);
> +
> +	list_for_each_entry_safe(gpio_pin, tmp, &ipctl->gpio_configs, list) {
…
> +	}
> +
> +unlock:
> +	spin_unlock_irqrestore(&ipctl->gpio_configs_lock, flags);
> +}

How do you think about to apply another call “scoped_guard(spinlock_irqsave, &ipctl->gpio_configs_lock)” here?

Regards,
Markus