linux-kernel - Re: [PATCH v2 1/2] perf probe: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1nJdd3YF5YGvlqp@google.com>
Date: Wed, 11 Dec 2024 09:18:45 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: James Clark <james.clark@...aro.org>, linux-perf-users@...r.kernel.org,
	mhiramat@...nel.org, Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>, Leo Yan <leo.yan@....com>,
	Dima Kogan <dima@...retsauce.net>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] perf probe: Fix uninitialized variable

Hello,

On Wed, Dec 11, 2024 at 10:15:30AM -0300, Arnaldo Carvalho de Melo wrote:
> On Wed, Dec 11, 2024 at 08:55:23AM +0000, James Clark wrote:
> > Since the linked fixes: commit, err is returned uninitialized due to the
> > removal of "return 0". Initialize err to fix it.
> > 
> > This fixes the following intermittent test failure on release builds:
> > 
> >  $ perf test "testsuite_probe"
> >  ...
> >  -- [ FAIL ] -- perf_probe :: test_invalid_options :: mutually exclusive options :: -L foo -V bar (output regexp parsing)
> >  Regexp not found: \"Error: switch .+ cannot be used with switch .+\"
> >  ...
> 
> So Namhyung, this one should go to perf-tools, I can pick the second on
> perf-tools-next, so that we keep perf-tools as small as possible.

Sure, will replace and force-push.

Thanks,
Namhyung