linux-kernel - Re: [PATCH] perf ftrace: Fix undefined behavior in cmp_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173393782213.3536107.18239500348967688224.b4-ty@kernel.org>
Date: Wed, 11 Dec 2024 09:23:42 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: peterz@...radead.org, mingo@...hat.com, acme@...nel.org, 
 Kuan-Wei Chiu <visitorckw@...il.com>
Cc: mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
 jolsa@...nel.org, irogers@...gle.com, kan.liang@...ux.intel.com, 
 adrian.hunter@...el.com, jserv@...s.ncku.edu.tw, chuang@...nycu.edu.tw, 
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
 stable@...r.kernel.org
Subject: Re: [PATCH] perf ftrace: Fix undefined behavior in
 cmp_profile_data()

On Mon, 09 Dec 2024 21:42:26 +0800, Kuan-Wei Chiu wrote:

> The comparison function cmp_profile_data() violates the C standard's
> requirements for qsort() comparison functions, which mandate symmetry
> and transitivity:
> 
> * Symmetry: If x < y, then y > x.
> * Transitivity: If x < y and y < z, then x < z.
> 
> [...]

Applied to perf-tools, thanks!

Best regards,
Namhyung