linux-kernel - Re: [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to refresh directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173393782275.3536107.5111642491226236063.b4-ty@kernel.org>
Date: Wed, 11 Dec 2024 09:23:42 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Mark Rutland <mark.rutland@....com>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
 Kan Liang <kan.liang@...ux.intel.com>, linux-perf-users@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v1 1/2] perf hwmon_pmu: Use openat rather than dup to
 refresh directory

On Thu, 05 Dec 2024 20:23:05 -0800, Ian Rogers wrote:

> The hwmon PMU test will make a temp directory, open the directory with
> O_DIRECTORY then fill it with contents. As the open is before the
> filling the contents the later fdopendir may reflect the initial empty
> state, meaning no events are seen. Change to re-open the directory,
> rather than dup the fd, so the latest contents are seen.
> 
> Minor tweaks/additions to debug messages.
> 
> [...]

Applied to perf-tools, thanks!

Best regards,
Namhyung