linux-kernel - Re: [PATCH] rust: Fix EXPORT_SYMBOL_RUST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kYsb0AwDC-AEKUGpFK4gzj1nd9jukrM+gesssjF6hveA@mail.gmail.com>
Date: Wed, 11 Dec 2024 19:28:22 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: eisantosh95@...il.com
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines

On Wed, Dec 11, 2024 at 7:16 PM <eisantosh95@...il.com> wrote:
>
> From: Santosh Mahto <eisantosh95@...il.com>
>
> Warning found by checkpatch.pl script.

Thanks for the patch!

Which warning? I guess you mean:

    WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

But this is not a normal use of `EXPORT_SYMBOL*()`, and anyway the
patch would break the build since the name is not declared otherwise.

Did you try to build the kernel after the patch with Rust enabled?

Cheers,
Miguel