linux-kernel - Re: [PATCH] memory: omap-gpmc: deadcode a pair of functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1oHn6D2PuJGV-3y@gallifrey>
Date: Wed, 11 Dec 2024 21:43:59 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: rogerq@...nel.org, tony@...mide.com, krzk@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: omap-gpmc: deadcode a pair of functions

* Dr. David Alan Gilbert (linux@...blig.org) wrote:
> * kernel test robot (lkp@...el.com) wrote:
> > Hi,
> > 
> > kernel test robot noticed the following build warnings:
> 
> Good bot!
> 
> > [auto build test WARNING on krzk-mem-ctrl/for-next]
> > [also build test WARNING on linus/master v6.13-rc2 next-20241211]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/linux-treblig-org/memory-omap-gpmc-deadcode-a-pair-of-functions/20241211-062027
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl.git for-next
> > patch link:    https://lore.kernel.org/r/20241210220628.237604-1-linux%40treblig.org
> > patch subject: [PATCH] memory: omap-gpmc: deadcode a pair of functions
> > config: i386-buildonly-randconfig-002-20241211 (https://download.01.org/0day-ci/archive/20241211/202412111932.lp8jHbeT-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241211/202412111932.lp8jHbeT-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202412111932.lp8jHbeT-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> drivers/memory/omap-gpmc.c:361:21: warning: 'gpmc_clk_ticks_to_ns' defined but not used [-Wunused-function]
> >      361 | static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
> >          |                     ^~~~~~~~~~~~~~~~~~~~
> 
> Ooh, right, I'll clean that out as well and send a v2.

OK, slightly more complicated, I've posted it as 20241211214227.107980-1-linux@...blig.org
gpmc_clk_ticks_to_ns is still used, but only inside a function which is ifdef'd, so I've
moved it inside the ifdef.

Dave

> Dave
> 
> > 
> > 
> > vim +/gpmc_clk_ticks_to_ns +361 drivers/memory/omap-gpmc.c
> > 
> > a3551f5b0c3ca7a arch/arm/mach-omap2/gpmc.c Adrian Hunter 2010-12-09  360  
> > 3950fffdf0c088d drivers/memory/omap-gpmc.c Baoyou Xie    2016-08-28 @361  static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
> > 7f2e8c58ae9e352 drivers/memory/omap-gpmc.c Robert ABEL   2015-02-27  362  					 enum gpmc_clk_domain cd)
> > 7f2e8c58ae9e352 drivers/memory/omap-gpmc.c Robert ABEL   2015-02-27  363  {
> > 7f2e8c58ae9e352 drivers/memory/omap-gpmc.c Robert ABEL   2015-02-27  364  	return ticks * gpmc_get_clk_period(cs, cd) / 1000;
> > 7f2e8c58ae9e352 drivers/memory/omap-gpmc.c Robert ABEL   2015-02-27  365  }
> > 7f2e8c58ae9e352 drivers/memory/omap-gpmc.c Robert ABEL   2015-02-27  366  
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/