linux-kernel - Re: linux-next: build failure after merge of the xfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vtxk3tdzp6eim5bsmlio4rlahuq2lbrjrgawunhvc7ecqn7yfy@yjkxfdmdsft6>
Date: Wed, 11 Dec 2024 22:41:29 +0100
From: Carlos Maiolino <cem@...nel.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: David Chinner <david@...morbit.com>, 
	"Darrick J. Wong" <djwong@...nel.org>, linux-xfs@...r.kernel.org, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the xfs tree

On Wed, Dec 11, 2024 at 09:04:45AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the xfs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> fs/xfs/xfs_trans.c: In function '__xfs_trans_commit':
> fs/xfs/xfs_trans.c:869:40: error: macro "xfs_trans_apply_dquot_deltas" requires 2 arguments, but only 1 given
>   869 |         xfs_trans_apply_dquot_deltas(tp);
>       |                                        ^
> In file included from fs/xfs/xfs_trans.c:15:
> fs/xfs/xfs_quota.h:176:9: note: macro "xfs_trans_apply_dquot_deltas" defined here
>   176 | #define xfs_trans_apply_dquot_deltas(tp, a)
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   03d23e3ebeb7 ("xfs: don't lose solo dquot update transactions")
> 
> $ grep CONFIG_XFS_QUOTA .config
> # CONFIG_XFS_QUOTA is not set
> 
> I have used the xfs tree from next-20241210 for today.

I just pushed a few extra patches to xfs-linux/for-next, which includes the
failure to build without QUOTA config enabled.

I also did a build test on different configurations (and added a todo list to
improve build testing here), so, it should be ok for you to pull it now Stephen.

Let me know please if you find some other issue.

Have a nice day out there.

Carlos