linux-kernel - Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1oI6cAAhGrcIVw9@gallifrey>
Date: Wed, 11 Dec 2024 21:49:29 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: dlemoal@...nel.org, cassel@...nel.org, p.zabel@...gutronix.de,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: sata_gemini: Remove unused
 gemini_sata_reset_bridge()

* Linus Walleij (linus.walleij@...aro.org) wrote:
> On Wed, Dec 11, 2024 at 2:12 AM <linux@...blig.org> wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> >
> > gemini_sata_reset_bridge() was added in 2017 by the initial
> > commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> > but has never been used.
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> 
> Right it was never used because the corresponding reset in
> the low-level PATA driver didn't work so I patched it out before
> submitting.

Ah right.

> But should you not also remove sata0_reset and
> sata1_reset from struct sata_gemini and the code fetching
> the two reset lines? And even #include <linux/reset.h>?

Oh I see, I was just looking for entirely unreferenced functions
but that takes a little more following to notice.

I'm happy to do that; are you OK with it as a follow up patch or
do you want a v2? (And can you test it, I don't have the hardware).

Dave

> Yours,
> Linus Walleij
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/