linux-kernel - Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaarPM3vx6vAVhdSv+KHDZq6MTDo0JpQYGj1gJnaE7OrQ@mail.gmail.com>
Date: Wed, 11 Dec 2024 11:34:34 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: linux@...blig.org
Cc: dlemoal@...nel.org, cassel@...nel.org, p.zabel@...gutronix.de, 
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

On Wed, Dec 11, 2024 at 2:12 AM <linux@...blig.org> wrote:

> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> gemini_sata_reset_bridge() was added in 2017 by the initial
> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> but has never been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Right it was never used because the corresponding reset in
the low-level PATA driver didn't work so I patched it out before
submitting.

But should you not also remove sata0_reset and
sata1_reset from struct sata_gemini and the code fetching
the two reset lines? And even #include <linux/reset.h>?

Yours,
Linus Walleij