linux-kernel - RE: [PATCH v3 0/6] Configure imx8mp dsp node for rproc usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459FE7FA7114C0F272E3FD1883E2@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 11 Dec 2024 07:16:28 +0000
From: Peng Fan <peng.fan@....com>
To: Daniel Baluta <daniel.baluta@....com>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "robh@...nel.org"
	<robh@...nel.org>
CC: "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "festevam@...il.com" <festevam@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Frank Li <frank.li@....com>, Aisheng Dong
	<aisheng.dong@....com>, "daniel.baluta@...il.com" <daniel.baluta@...il.com>,
	Laurentiu Mihalcea <laurentiu.mihalcea@....com>, "S.J. Wang"
	<shengjiu.wang@....com>, Iuliana Prodan <iuliana.prodan@....com>,
	"a.fatoum@...gutronix.de" <a.fatoum@...gutronix.de>, Daniel Baluta
	<daniel.baluta@....com>
Subject: RE: [PATCH v3 0/6] Configure imx8mp dsp node for rproc usage

> Subject: [PATCH v3 0/6] Configure imx8mp dsp node for rproc usage
> 
> DSP found in i.MX8MP SOC can be used by multiple frameworks in
> order to enable various applications:
>         - rproc/rpmsg framework, used to load for example Zephyr
> samples
>         - Sound Open Firmware, used to enable various audio processing
>           pipelines.
> 
> Current dsp node was configured with SOF in mind but it doesn't work
> well with imx8mp-evk dts. SOF controls audio IPs from firmware side
> while imx8mp-evk preffers to control audio IPs from Linux side.
> 
> So, configure 'dsp' node to be used with rproc scenario and later will
> add a separate dts or an overlay to configure the node for SOF.
> 
> This patch series configures and enables dsp node to be used with
> rproc.
> 
> Changes since v1:
>         - document syscon compatible as pointed by Peng Fan
>         - do not disable dsp_reserved node in the dtsi file as pointed
>           by Ahmad Fatoum.
> Changes since v2:
>         - Fix dts example in patch 4/6
>         - Frank Li commented that we should handle the reset using the
> reset
>         interface. I have two objections on this: we are using some bits
> from audiomix
>         for reset together some other bits from DAP region. Also, the
> implementation is already upstream!
>         Frank Li agreed that it's up to Rob opinion on this.
> 
> Daniel Baluta (6):
>   arm64: dts: imx8mp: Add mu2 root clock
>   arm64: dts: imx8mp: Configure dsp node for rproc usage
>   arm64: dts: imx8mp: Add DSP clocks
>   dt-bindings: clock: imx8mp: Add syscon compatible
>   arm64: dts: imx8mp: Add fsl,dsp-ctrl property for dsp
>   arm64: dts: Add dsp rproc related mem regions
> 
>  .../bindings/clock/imx8mp-audiomix.yaml       |  6 +++--
>  arch/arm64/boot/dts/freescale/imx8mp-evk.dts  | 10 +++++++++
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi     | 22 ++++++++++++------
> -
>  3 files changed, 28 insertions(+), 10 deletions(-)
> 

Patchset looks good to me:

Reviewed-by: Peng Fan <peng.fan@....com>