linux-kernel - Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ad17f6-cc1a-48c2-92b6-31d2464946d6@intel.com>
Date: Wed, 11 Dec 2024 08:16:56 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Ming Yu <a0282524688@...il.com>, <tmyu0@...oton.com>, <lee@...nel.org>,
	<linus.walleij@...aro.org>, <brgl@...ev.pl>, <andi.shyti@...nel.org>,
	<mkl@...gutronix.de>, <mailhol.vincent@...adoo.fr>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<wim@...ux-watchdog.org>, <linux@...ck-us.net>, <jdelvare@...e.com>,
	<alexandre.belloni@...tlin.com>, <linux-kernel@...r.kernel.org>,
	<linux-gpio@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
	<linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-watchdog@...r.kernel.org>, <linux-hwmon@...r.kernel.org>,
	<linux-rtc@...r.kernel.org>
Subject: Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694



On 12/11/2024 2:56 AM, Jakub Kicinski wrote:
> On Tue, 10 Dec 2024 11:57:41 +0100 Mateusz Polchlopek wrote:
>>> +int nct6694_read_msg(struct nct6694 *nct6694, u8 mod, u16 offset,
>>> +		     u16 length, void *buf)
>>> +{
>>> +	struct nct6694_cmd_header *cmd_header = nct6694->cmd_header;
>>> +	struct nct6694_response_header *response_header = nct6694->response_header;
>>
>> RCT violation
> 
> This code is not under net not drivers/net
> As a general rule please focus on functional review, formatting and
> process issues are harder to judge unless you read all of the mailing
> list traffic.

Okay, my bad. Thanks Kuba for explanation and I will focus on code next
time