linux-kernel - Re: [PATCH v2 1/1] dt-bindings: PCI: mobiveil: convert mobiveil-pcie.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e5e8390-9602-4ee5-9940-40e195a0b521@kernel.org>
Date: Wed, 11 Dec 2024 09:12:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Frank Li <Frank.Li@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>,
 Hou Zhiqiang <Zhiqiang.Hou@....com>, Frank <Li@....com>,
 "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS"
 <linux-pci@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: PCI: mobiveil: convert
 mobiveil-pcie.txt to yaml format

On 10/12/2024 18:07, Bjorn Helgaas wrote:
> On Tue, Dec 10, 2024 at 09:42:31AM +0100, Krzysztof Kozlowski wrote:
>> On Mon, Dec 09, 2024 at 05:51:21PM -0600, Bjorn Helgaas wrote:
>>> On Fri, Dec 06, 2024 at 05:25:27PM -0500, Frank Li wrote:
>>>> Convert device tree binding doc mobiveil-pcie.txt to yaml format. Merge
>>>> layerscape-pcie-gen4.txt into this file.
>>>>
>>>> Additional change:
>>>> - interrupt-names: "aer", "pme", "intr", which align order in examples.
>>>> - reg-names: csr_axi_slave, config_axi_slave, which align existed dts file.
>>>
>>> Is there any way to split this into two patches:
>>>
>>>   - Convert to yaml and update MAINTAINERS
>>>   - Update interrupt-names, reg-names
>>>
>>> It's hard to review the interrupt-names, reg-names when they're mixed
>>> in with the yaml conversion.
>>
>> The conversion should result in a correct binding, so if original
>> binding had some issues (and TXT bindings often have: missing or
>> stale/not-udpated properties), then we expect any fixes in the same
>> commit.  New things, not supported by existing in-kernel upstream users
>> or bindings, should be of course in separate patch.
> 
> Maybe they could be added to the original TXT binding first in one
> patch, and then converted to yaml in a second patch?


This would solve one thing and cause another issues: you add lines in
one commit which are immediately removed in the next commit, plus we
don't want any changes in TXT because absolute lack of means for
verification/testing.


Best regards,
Krzysztof