linux-kernel - Re: [PATCH v2] arm64: zynqmp: add clock-output-names property in clock nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <844282e1-1c69-4d66-bd98-f9188901c7ac@amd.com>
Date: Wed, 11 Dec 2024 12:48:59 +0100
From: Michal Simek <michal.simek@....com>
To: Naman Trivedi <naman.trivedimanojbhai@....com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, senthilnathan.thangaraj@....com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: zynqmp: add clock-output-names property in
 clock nodes



On 11/22/24 10:57, Naman Trivedi wrote:
> Add clock-output-names property to clock nodes, so that the resulting
> clock name do not change when clock node name is changed.
> Also, replace underscores with hyphens in the clock node names as per
> dt-schema rule.
> 
> Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@....com>
> ---
> v1: https://lore.kernel.org/all/c5d6effa-bdcf-49e3-a4bf-3713db889b70@kernel.org
> Changes v1 -> v2:
> - Fix the clock node names by replacing underscore with hyphen.
> ---
>   arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> index 60d1b1acf9a0..385fed8a852a 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> @@ -10,39 +10,44 @@
>   
>   #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
>   / {
> -	pss_ref_clk: pss_ref_clk {
> +	pss_ref_clk: pss-ref-clk {
>   		bootph-all;
>   		compatible = "fixed-clock";
>   		#clock-cells = <0>;
>   		clock-frequency = <33333333>;
> +		clock-output-names = "pss_ref_clk";
>   	};
>   
> -	video_clk: video_clk {
> +	video_clk: video-clk {
>   		bootph-all;
>   		compatible = "fixed-clock";
>   		#clock-cells = <0>;
>   		clock-frequency = <27000000>;
> +		clock-output-names = "video_clk";
>   	};
>   
> -	pss_alt_ref_clk: pss_alt_ref_clk {
> +	pss_alt_ref_clk: pss-alt-ref-clk {
>   		bootph-all;
>   		compatible = "fixed-clock";
>   		#clock-cells = <0>;
>   		clock-frequency = <0>;
> +		clock-output-names = "pss_alt_ref_clk";
>   	};
>   
> -	gt_crx_ref_clk: gt_crx_ref_clk {
> +	gt_crx_ref_clk: gt-crx-ref-clk {
>   		bootph-all;
>   		compatible = "fixed-clock";
>   		#clock-cells = <0>;
>   		clock-frequency = <108000000>;
> +		clock-output-names = "gt_crx_ref_clk";
>   	};
>   
> -	aux_ref_clk: aux_ref_clk {
> +	aux_ref_clk: aux-ref-clk {
>   		bootph-all;
>   		compatible = "fixed-clock";
>   		#clock-cells = <0>;
>   		clock-frequency = <27000000>;
> +		clock-output-names = "aux_ref_clk";
>   	};
>   };
>   

Apply.

M