linux-kernel - Re: [PATCH v1 1/8] ARM: dts: aspeed: system1: Add IPMB device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45b55b4b-25e4-4e8b-8c95-8c3129e72227@kernel.org>
Date: Fri, 13 Dec 2024 16:48:45 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ninad Palsule <ninad@...ux.ibm.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, joel@....id.au, andrew@...econstruct.com.au,
 devicetree@...r.kernel.org, eajames@...ux.ibm.com,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Cc: NINAD PALSULE <ninadpalsule@...ibm.com>
Subject: Re: [PATCH v1 1/8] ARM: dts: aspeed: system1: Add IPMB device

On 13/12/2024 15:50, Ninad Palsule wrote:
> From: NINAD PALSULE <ninadpalsule@...ibm.com>
> 
> Add IPMB device sitting behind PCH module
> 
> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index 8f77bc9e860c..51a116d7041a 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -763,6 +763,16 @@ i2c3mux0chn7: i2c@7 {
>  
>  &i2c4 {
>  	status = "okay";
> +	multi-master;
> +	bus-frequency = <1000000>;
> +
> +	//Set bmc' slave address;

Is this relevant/useful comment? Why is it even here?

> +	bmc_slave@10 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Also: use DTS coding style (there are no underscores in node names) and
use preferred naming scheme (see general kernel coding style / naming).



Best regards,
Krzysztof