linux-kernel - Re: [PATCH v1 7/8] ARM: dts: aspeed: system1: Mark GPIO line high/low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de59078c-8410-4c4f-bfce-db402e92635c@kernel.org>
Date: Fri, 13 Dec 2024 16:49:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ninad Palsule <ninad@...ux.ibm.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, joel@....id.au, andrew@...econstruct.com.au,
 devicetree@...r.kernel.org, eajames@...ux.ibm.com,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Cc: NINAD PALSULE <ninadpalsule@...ibm.com>
Subject: Re: [PATCH v1 7/8] ARM: dts: aspeed: system1: Mark GPIO line high/low

On 13/12/2024 15:50, Ninad Palsule wrote:
> From: NINAD PALSULE <ninadpalsule@...ibm.com>
> 
> - Mark following GPIO lines as input high:
>   - GPIOL4 (reset PCH registers)
>   - GPIOL5 (reset portition of intel ME)
> - Mark isolate errors from cpu1 gpio (GPIOO6) as active low output.
> - The fan controller reset line should be active high.
> 
> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com>
> ---
>  .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index ca2d4a292687..be0cd6152c61 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -383,6 +383,34 @@ &gpio0 {
>  	/*X0-X7*/	"fpga-pgood","power-chassis-good","pch-pgood","","","","","",
>  	/*Y0-Y7*/	"","","","","","","","",
>  	/*Z0-Z7*/	"","","","","","","","";
> +
> +	rtc_reset {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.

Best regards,
Krzysztof