linux-kernel - Re: [PATCH net-next 11/12] jump_label: export static_key_slow_{inc,dec}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4af5958-38bd-44c3-b539-8e112a0c0be6@intel.com>
Date: Fri, 13 Dec 2024 18:22:51 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov
	<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, John Fastabend
	<john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, "Peter
 Zijlstra" <peterz@...radead.org>, "Jose E. Marchesi"
	<jose.marchesi@...cle.com>, Toke Høiland-Jørgensen
	<toke@...hat.com>, Magnus Karlsson <magnus.karlsson@...el.com>, "Maciej
 Fijalkowski" <maciej.fijalkowski@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, Jason Baron <jbaron@...mai.com>, "Casey
 Schaufler" <casey@...aufler-ca.com>, Nathan Chancellor <nathan@...nel.org>,
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <bpf@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 11/12] jump_label: export
 static_key_slow_{inc,dec}_cpuslocked()

From: Josh Poimboeuf <jpoimboe@...nel.org>
Date: Wed, 11 Dec 2024 09:40:00 -0800

> On Wed, Dec 11, 2024 at 06:26:48PM +0100, Alexander Lobakin wrote:
>> Sometimes, there's a need to modify a lot of static keys or modify the
>> same key multiple times in a loop. In that case, it seems more optimal
>> to lock cpu_read_lock once and then call _cpuslocked() variants.
>> The enable/disable functions are already exported, the refcounted
>> counterparts however are not. Fix that to allow modules to save some
>> cycles.
>>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
>> ---
>>  kernel/jump_label.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/kernel/jump_label.c b/kernel/jump_label.c
>> index 93a822d3c468..1034c0348995 100644
>> --- a/kernel/jump_label.c
>> +++ b/kernel/jump_label.c
>> @@ -182,6 +182,7 @@ bool static_key_slow_inc_cpuslocked(struct static_key *key)
>>  	}
>>  	return true;
>>  }
>> +EXPORT_SYMBOL_GPL(static_key_slow_inc_cpuslocked);
>>  
>>  bool static_key_slow_inc(struct static_key *key)
>>  {
>> @@ -342,6 +343,7 @@ void static_key_slow_dec_cpuslocked(struct static_key *key)
>>  	STATIC_KEY_CHECK_USE(key);
>>  	__static_key_slow_dec_cpuslocked(key);
>>  }
>> +EXPORT_SYMBOL_GPL(static_key_slow_dec_cpuslocked);
> 
> Where's the code which uses this?

It's not in this series -- the initial one was too large, so it was split.

Thanks,
Olek