linux-kernel - Re: [PATCH v12 2/2] rust: xarray: Add an abstraction for XArray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mvQAmU4HAypfh7iwX1DmJg48wHJU-sr+_Jg1M3n2GUzg@mail.gmail.com>
Date: Fri, 13 Dec 2024 18:23:08 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Danilo Krummrich <dakr@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Maíra Canal <mcanal@...lia.com>, 
	Asahi Lina <lina@...hilina.net>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 2/2] rust: xarray: Add an abstraction for XArray

On Fri, Dec 13, 2024 at 5:25 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> That's a fair assessment, but it's a subjective area -- Andreas was
> fond of the approach (in a preview review).

Some things are subjective, yet we pick particular options and have guidelines.

I think we should generally refrain ourselves from making code
non-obvious for others that are still learning Rust and its standard
library, unless there is an actual advantage writing the code a
particular way.

Over time, when more kernel developers are somewhat familiar with
Rust, then sure. This is also how other features in kernel C have been
introduced.

Cheers,
Miguel