linux-kernel - Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cbb8f3f6-2ae3-c21d-478a-c0fb3dea385d@quicinc.com>
Date: Fri, 13 Dec 2024 11:11:00 -0700
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Lizhi Hou <lizhi.hou@....com>, Arnd Bergmann <arnd@...nel.org>,
        Min Ma
	<min.ma@....com>, Oded Gabbay <ogabbay@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>,
        Narendra Gutta
	<VenkataNarendraKumar.Gutta@....com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

On 12/13/2024 10:57 AM, Lizhi Hou wrote:
> 
> On 12/13/24 09:49, Jeffrey Hugo wrote:
>> On 12/13/2024 10:41 AM, Lizhi Hou wrote:
>>>
>>> On 12/13/24 09:07, Jeffrey Hugo wrote:
>>>> On 12/13/2024 2:02 AM, Arnd Bergmann wrote:
>>>>> From: Arnd Bergmann <arnd@...db.de>
>>>>>
>>>>> The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause 
>>>>> a build
>>>>> warning when CONFIG_PM is disabled:
>>>>>
>>>>> drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error: 
>>>>> 'amdxdna_pmops_resume' defined but not used [-Werror=unused-function]
>>>>>    343 | static int amdxdna_pmops_resume(struct device *dev)
>>>>>        |            ^~~~~~~~~~~~~~~~~~~~
>>>>> drivers/accel/amdxdna/amdxdna_pci_drv.c:328:12: error: 
>>>>> 'amdxdna_pmops_suspend' defined but not used [-Werror=unused-function]
>>>>>    328 | static int amdxdna_pmops_suspend(struct device *dev)
>>>>>        |            ^~~~~~~~~~~~~~~~~~~~~
>>>>>
>>>>> Change these to the modern replacements.
>>>>>
>>>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>>>
>>>> Looks sane to me.
>>>>
>>>> Lizhi, can you verify that this works as expected for you? I'd hate 
>>>> to accidentally break something.
>>>
>>> Verified suspend/resume. It works fine.
>>
>> Excellent.  Would you like to give a reviewed-by and/or a tested-by?
> 
> Reviewed-by: Lizhi Hou <lizhi.hou@....com>
> 
> Tested-by: Lizhi Hou <lizhi.hou@....com>

Thanks!

Pushed to drm-misc-next

-Jeff