linux-kernel - Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r06crnew.fsf@kernel.org>
Date: Fri, 13 Dec 2024 10:35:03 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Petr Mladek <pmladek@...e.com>
Cc: Yafang Shao <laoar.shao@...il.com>,  torvalds@...ux-foundation.org,
  akpm@...ux-foundation.org,  linux-kernel@...r.kernel.org,
  linux-security-module@...r.kernel.org,  x86@...nel.org,
  linux-snps-arc@...ts.infradead.org,  linux-wireless@...r.kernel.org,
  intel-gfx@...ts.freedesktop.org,  intel-xe@...ts.freedesktop.org,
  nouveau@...ts.freedesktop.org,  dri-devel@...ts.freedesktop.org,
  ocfs2-devel@...ts.linux.dev,  Steven Rostedt <rostedt@...dmis.org>,  Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>,  Rasmus Villemoes
 <linux@...musvillemoes.dk>,  Sergey Senozhatsky
 <senozhatsky@...omium.org>,  Andy Whitcroft <apw@...onical.com>,  Joe
 Perches <joe@...ches.com>,  Dwaipayan Ray <dwaipayanray1@...il.com>,
  Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

Petr Mladek <pmladek@...e.com> writes:

> On Fri 2024-12-13 13:46:04, Yafang Shao wrote:
>> Since the task->comm is guaranteed to be NUL-ternimated, we can print it
>> directly. Add a new vsnprintf format specifier "%pTN" to print task comm,
>> where 'p' represents the task Pointer, 'T' stands for Task, and 'N' denots
>> Name. With this abstraction, the user no longer needs to care about
>> retrieving task name.
>
> What is the advantage, please?
>
> Honestly, I believe that the meaning of
>
> 	printk("%s\n", task->comm);
>
> is much more clear than using a cryptic %pXYZ modifier:
>
> 	printk("%pTN\n", task);
>
>
> The %pXYZ modifiers makes sense only when the formatting of the printed
> information needs some processing. But this is a plain string.
> IMHO, it is not worth it. In fact, I believe that it is a
> counter productive.

I agree, it makes the code harder to read for someone who is not
familiar with all the %p magic we have (like me).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches