linux-kernel - [PATCH] PCI: Remove redundant macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241213094617.1149-1-zhangdongdong@eswincomputing.com>
Date: Fri, 13 Dec 2024 17:46:17 +0800
From: zhangdongdong@...incomputing.com
To: alex.williamson@...hat.com
Cc: bhelgaas@...gle.com,
	zhangdongdong@...incomputing.com,
	yishaih@...dia.com,
	avihaih@...dia.com,
	yi.l.liu@...el.com,
	ankita@...dia.com,
	kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: [PATCH] PCI: Remove redundant macro

From: Dongdong Zhang <zhangdongdong@...incomputing.com>

Removed the duplicate macro definition PCI_VSEC_HDR from
pci_regs.h to avoid redundancy. Updated the VFIO PCI code
to use the existing `PCI_VNDR_HEADER` macro for consistency,
ensuring minimal changes to the codebase.

Signed-off-by: Dongdong Zhang <zhangdongdong@...incomputing.com>
---
 drivers/vfio/pci/vfio_pci_config.c | 3 ++-
 include/uapi/linux/pci_regs.h      | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
index ea2745c1ac5e..c30748912ff1 100644
--- a/drivers/vfio/pci/vfio_pci_config.c
+++ b/drivers/vfio/pci/vfio_pci_config.c
@@ -1389,7 +1389,8 @@ static int vfio_ext_cap_len(struct vfio_pci_core_device *vdev, u16 ecap, u16 epo
 
 	switch (ecap) {
 	case PCI_EXT_CAP_ID_VNDR:
-		ret = pci_read_config_dword(pdev, epos + PCI_VSEC_HDR, &dword);
+		ret = pci_read_config_dword(pdev, epos + PCI_VNDR_HEADER,
+					    &dword);
 		if (ret)
 			return pcibios_err_to_errno(ret);
 
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 1601c7ed5fab..7b6cad788de3 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -1001,7 +1001,6 @@
 #define PCI_ACS_CTRL		0x06	/* ACS Control Register */
 #define PCI_ACS_EGRESS_CTL_V	0x08	/* ACS Egress Control Vector */
 
-#define PCI_VSEC_HDR		4	/* extended cap - vendor-specific */
 #define  PCI_VSEC_HDR_LEN_SHIFT	20	/* shift for length field */
 
 /* SATA capability */
-- 
2.17.1