linux-kernel - Re: [PATCH] Bluetooth: btmtk: add quirk to support HCI_QUIRK_SIMULTANEOUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bbe0989-babd-4a99-85ad-fdeea47deb09@molgen.mpg.de>
Date: Fri, 13 Dec 2024 10:46:00 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Chris Lu <chris.lu@...iatek.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Von Dentz <luiz.dentz@...il.com>, Hao Qin <hao.qin@...iatek.com>,
 Aaron Hou <aaron.hou@...iatek.com>, Steve Lee <steve.lee@...iatek.com>,
 linux-bluetooth <linux-bluetooth@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 linux-mediatek <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] Bluetooth: btmtk: add quirk to support
 HCI_QUIRK_SIMULTANEOUS_DISCOVERY

Dear Chris,


Thank you for your patch.


Am 13.12.24 um 10:41 schrieb Chris Lu:
> Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for MT79xx
> series chipset.

It’d be great if you elaborated. What is the problem. Why is a quirk 
needed? Is a firmware update going to fix it?

> Signed-off-by: Chris Lu <chris.lu@...iatek.com>
> ---
>   drivers/bluetooth/btmtk.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
> index 8a3f7c3fcfec..562d6ecf0b71 100644
> --- a/drivers/bluetooth/btmtk.c
> +++ b/drivers/bluetooth/btmtk.c
> @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev)
>   			return err;
>   		}
>   
> +		/* Apply common HCI quirks for MediaTek chipset */
> +		set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
> +

The commit message only talks about MT79xx series chipset. The comment 
talks about all MediaTek chipsets.

>   		hci_set_msft_opcode(hdev, 0xFD30);
>   		hci_set_aosp_capable(hdev);


Kind regards,

Paul