linux-kernel - Re: [PATCH] Bluetooth: btmtk: add quirk to support HCI_QUIRK_SIMULTANEOUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa8b24291fd5c88f65e6e196796c16de6102b27a.camel@mediatek.com>
Date: Mon, 16 Dec 2024 02:44:15 +0000
From: Chris Lu (陸稚泓) <Chris.Lu@...iatek.com>
To: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>
CC: "marcel@...tmann.org" <marcel@...tmann.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	"johan.hedberg@...il.com" <johan.hedberg@...il.com>,
	Steve Lee (李視誠) <steve.lee@...iatek.com>,
	Aaron Hou (侯俊仰) <Aaron.Hou@...iatek.com>,
	Hao Qin (秦浩) <Hao.Qin@...iatek.com>,
	"luiz.dentz@...il.com" <luiz.dentz@...il.com>
Subject: Re: [PATCH] Bluetooth: btmtk: add quirk to support
 HCI_QUIRK_SIMULTANEOUS_DISCOVERY

Hi Paul,

Thanks for your input,

On Fri, 2024-12-13 at 10:46 +0100, Paul Menzel wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Dear Chris,
> 
> 
> Thank you for your patch.
> 
> 
> Am 13.12.24 um 10:41 schrieb Chris Lu:
> > Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for
> > MT79xx
> > series chipset.
> 
> It’d be great if you elaborated. What is the problem. Why is a quirk
> needed? Is a firmware update going to fix it?

This quirk is related to do BR/EDR inquiry and LE scan simultaneously.
More detailed was described in hci.h.

Due to requirement from customer and other chip vendors also enable
HCI_QUIRK_SIMULTANEOUS_DISCOVERY, MediaTek upload this patch to enable
the feature as well. There is no need to update firmware.

> 
> > Signed-off-by: Chris Lu <chris.lu@...iatek.com>
> > ---
> >   drivers/bluetooth/btmtk.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
> > index 8a3f7c3fcfec..562d6ecf0b71 100644
> > --- a/drivers/bluetooth/btmtk.c
> > +++ b/drivers/bluetooth/btmtk.c
> > @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev)
> >                       return err;
> >               }
> > 
> > +             /* Apply common HCI quirks for MediaTek chipset */
> > +             set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev-
> > >quirks);
> > +
> 
> The commit message only talks about MT79xx series chipset. The
> comment
> talks about all MediaTek chipsets.
I'll modify commit message to avoid ambiguity and upload another
version.

Thanks a lot,
Chris Lu
> 
> >               hci_set_msft_opcode(hdev, 0xFD30);
> >               hci_set_aosp_capable(hdev);
> 
> 
> Kind regards,
> 
> Paul