linux-kernel - Re: [PATCH net 0/2] net: Fix 2 OF device node refcount leakage issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34d1ccdf-f4dd-44c0-afb5-fe1c7fe49a61@icloud.com>
Date: Fri, 13 Dec 2024 18:50:52 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Justin Chen <justin.chen@...adcom.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH net 0/2] net: Fix 2 OF device node refcount leakage issues

On 2024/12/12 23:33, Kory Maincent wrote:
> On Thu, 12 Dec 2024 23:06:53 +0800
> Zijun Hu <zijun_hu@...oud.com> wrote:
> 
>> This patch series is to fix 2 OF device node refcount leakage issues.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
>> ---
>> Zijun Hu (2):
>>       net: pse-pd: tps23881: Fix device node refcount leakage in
>> tps23881_get_of_channels() net: bcmasp: Fix device node refcount leakage in
>> bcmasp_probe()
> 
> Thanks for the patch. This fix was already sent by Zhang Zekun:
> https://lore.kernel.org/netdev/20241024015909.58654-1-zhangzekun11@huawei.com/
> 
thank you for sharing this info.

> net maintainers would prefer to have the API changed as calling of_node_get
> before of_find_node_by_name is not intuitive.
> 

agree.

> Still, don't know if we should fix it until the API is changed?  
> 

(^^)
> Regards,