linux-kernel - Re: [PATCH mm-unstable v2 06/16] mm: csky: Introduce arch_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241212173934.4dc429716acd4c71a76e15c2@linux-foundation.org>
Date: Thu, 12 Dec 2024 17:39:34 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>
Cc: Kalesh Singh <kaleshsingh@...gle.com>, lorenzo.stoakes@...cle.com,
 vbabka@...e.cz, yang@...amperecomputing.com, riel@...riel.com,
 david@...hat.com, minchan@...nel.org, jyescas@...gle.com,
 linux@...linux.org.uk, tsbogend@...ha.franken.de,
 James.Bottomley@...senpartnership.com, ysato@...rs.sourceforge.jp,
 dalias@...c.org, glaubitz@...sik.fu-berlin.de, davem@...emloft.net,
 andreas@...sler.com, tglx@...utronix.de, bp@...en8.de,
 dave.hansen@...ux.intel.com, x86@...nel.org, chris@...kel.net,
 jcmvbkbc@...il.com, bhelgaas@...gle.com, jason.andryuk@....com,
 leitao@...ian.org, linux-alpha@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org,
 loongarch@...ts.linux.dev, linux-mips@...r.kernel.org,
 linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
 sparclinux@...r.kernel.org, linux-mm@...ck.org, kernel-team@...roid.com,
 android-mm@...gle.com
Subject: Re: [PATCH mm-unstable v2 06/16] mm: csky: Introduce
 arch_mmap_hint()

On Thu, 12 Dec 2024 16:40:10 -0500 "Liam R. Howlett" <Liam.Howlett@...cle.com> wrote:

> * Kalesh Singh <kaleshsingh@...gle.com> [241211 18:28]:
> > Introduce csky arch_mmap_hint() and define HAVE_ARCH_MMAP_HINT.
> > This is a preparatory patch, no functional change is introduced.
> 
> This also looks like it has changed the validation order and potentially
> introduced functional changes?
> 
> All these stem from the same cloned code (sparc32 iirc), but were not
> updated when the cloned code was updated.  This is why I am against
> arch_* code.  We should find a better way to unify the code so that
> there is nothing different.  You seem to have gotten some of the shared
> code together, but some still exists.
> 
> In the addresses, there are upper and lower limits, and sometimes
> "colours".  Could we not just define the upper/lower limits in each arch
> and if colour is used?  Maybe this is complicated with 32/64 handled
> both in the 64 bit code.
> 
> Is there any plan to unite this code further?
> 
> We have had errors for many years in cloned but not updated code.  I
> really wish there was more information in the cover letter on what is
> going on here.  I'd like to try and reduce the arch_ code to, basically
> nothing.
> 
> I was also disappointed that I wasn't Cc'ed because I've spent a lot of
> time in this code and this area.  I am probably the last one to crawl
> through and change any of this.

Thanks, I removed this version of this series from mm-unstable.