linux-kernel - Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: add support for default charge current limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c27b7edc-b64f-44e3-b847-513dc593cb46@kernel.org>
Date: Fri, 13 Dec 2024 15:32:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Dimitri Fedrau <dimitri.fedrau@...bherr.com>,
 Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: add support
 for default charge current limit

On 13/12/2024 15:19, Dimitri Fedrau wrote:
> 
>> But what I don't get is why GPIO chager needs it, since this is
>> non-configurable for GPIO charger.
>>
> With properties charge-current-limit-gpios and charge-current-limit-mapping
> one can define charge current limits in uA using up to 32 GPIOs. At the
> moment the driver defaults to smallest current limitation for safety
> reasons. When disabling charging should be possible as in the example,
> the charger defaults to non-charging. By having a default the charge
> current limit can be setup on probe and charging is enabled.

OK, the commit msg should explain the intention and real use case you
are solving here. Plus you miss the dependency - this property depends
on charge-current-limit-mapping.

Best regards,
Krzysztof