| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2e8e63f2-3a1b-4ca4-b095-4a6cbb20ae25@roeck-us.net> Date: Sat, 14 Dec 2024 06:30:11 -0800 From: Guenter Roeck <linux@...ck-us.net> To: Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-renesas-soc@...r.kernel.org Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org, Yury Norov <yury.norov@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk> Subject: Re: [RFC PATCH 1/2] bitops: add generic parity calculation for u8 On 12/14/24 06:19, Guenter Roeck wrote: > On 12/14/24 00:58, Wolfram Sang wrote: >> There are multiple open coded implementations for getting the parity of >> a byte in the kernel, even using different approaches. Take the pretty >> efficient version from SPD5118 driver and make it generally available by >> putting it into the bitops header. As long as there is just one parity >> calculation helper, the creation of a distinct 'parity.h' header was >> discarded. Also, the usage of hweight8() for architectures having a >> popcnt instruction is postponed until a use case within hot paths is >> desired. The motivation for this patch is the frequent use of odd parity >> in the I3C specification and to simplify drivers there. >> >> Changes compared to the original SPD5118 version are the addition of >> kernel documentation, switching the return type from bool to int, and >> renaming the argument of the function. >> > > Curious: Why not bool ? > Never mind. It returns the parity, after all, not "parity is odd". Thanks, Guenter
Powered by blists - more mailing lists