linux-kernel - Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebd71e3d-1902-402b-a84e-819b0976ba4b@baylibre.com>
Date: Sat, 14 Dec 2024 14:24:05 -0600
From: David Lechner <dlechner@...libre.com>
To: ahaslam@...libre.com, jic23@...nel.org
Cc: Michael.Hennerich@...log.com, robh@...nel.org, conor+dt@...nel.org,
 krzk+dt@...nel.org, linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

On 11/6/24 4:38 AM, ahaslam@...libre.com wrote:
> From: Axel Haslam <ahaslam@...libre.com>
> 
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
> 
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@...libre.com>
> ---
>  Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> index 79cb4b78a88a..2bd89e0aa46b 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> @@ -91,7 +91,7 @@ examples:
>              vrefn-supply = <&dac_vrefn>;
>              reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
>              clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
> -            ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
> +            ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
>          };
>      };
>  ...

Hi Jonathan, any reason this one didn't get picked up yet?