linux-kernel - Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04c6066f-b8ff-431c-a093-c25aedf58d3f@roeck-us.net>
Date: Sun, 15 Dec 2024 10:23:08 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Joshua Grisham <josh@...huagrisham.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, ilpo.jarvinen@...ux.intel.com,
 hdegoede@...hat.com, platform-driver-x86@...r.kernel.org, corbet@....net,
 linux-doc@...r.kernel.org, jdelvare@...e.com, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook
 driver

On 12/15/24 09:19, Joshua Grisham wrote:
> Den sön 15 dec. 2024 kl 17:35 skrev Guenter Roeck <linux@...ck-us.net>:
>>
>> Your v2 is highly unusual. The patch description is the change log,
>> and the patch itself seems to be a diff against v1. Did someone ask you
>> to do that ? Just wondering.
>>
>> Guenter
>>
> 
> Hi Guenter, here I was just following a patch guide (or at least,
> attempting to?); should it instead be a whole new patch against

Is that a Linux kernel patch guide ? Please provide a reference if possible.

> for-next instead of a diff from the v1 of the first patch itself?
> 

That would have been my expectation, and every revised patch series I have
seen so far did that. This is why I am curious and try to understand why
you didn't do that.

Thanks,
Guenter