linux-kernel - Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9f04bf6-18a0-4f6b-a6ff-2c6e493005e3@infradead.org>
Date: Sun, 15 Dec 2024 08:53:09 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Joshua Grisham <josh@...huagrisham.com>
Cc: ilpo.jarvinen@...ux.intel.com, hdegoede@...hat.com,
 platform-driver-x86@...r.kernel.org, corbet@....net,
 linux-doc@...r.kernel.org, jdelvare@...e.com, linux@...ck-us.net,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook
 driver



On 12/15/24 8:09 AM, Joshua Grisham wrote:
> Den mån 9 dec. 2024 kl 18:04 skrev Randy Dunlap <rdunlap@...radead.org>:
>>
>> Also needs <linux/sysfs.h>.
>> Maybe <linux/printk.h>.
>> Maybe <linux/err.h>.
>>
>> --
>> ~Randy
>>
> 
> Also done in v2 of the patch, thanks Randy! (though no printk.h
> anymore as I removed all pr_* functions.. maybe I should explicitly
> add <linux/dev_printk.h> though? or is it good enough to get it via
> platform_device.h <= device.h <= dev_printk.h  ?)
> 
> Joshua

from Documentation/process/submit-checklist.rst:

1) If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.


-- 
~Randy