linux-kernel - Re: [PATCH] staging: media: max96712: fix kernel oops when removing module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_2cXu0U=nJnxR+biK1ovXsq+pbcBYVV-C6ZwjWCrtsqzg@mail.gmail.com>
Date: Mon, 16 Dec 2024 18:05:51 +0100
From: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Cc: Niklas Söderlund <niklas.soderlund@...natech.se>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-kernel@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev, 
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, 
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Subject: Re: [PATCH] staging: media: max96712: fix kernel oops when removing module

Hi

You probably want to add:
diff --git a/drivers/staging/media/max96712/max96712.c
b/drivers/staging/media/max96712/max96712.c
index ede02e8c891c..a47f18d57325 100644
--- a/drivers/staging/media/max96712/max96712.c
+++ b/drivers/staging/media/max96712/max96712.c
@@ -418,7 +418,6 @@ static int max96712_probe(struct i2c_client *client)
        priv->info = of_device_get_match_data(&client->dev);

        priv->client = client;
-       i2c_set_clientdata(client, priv);

        priv->regmap = devm_regmap_init_i2c(client, &max96712_i2c_regmap);
        if (IS_ERR(priv->regmap))

That way it will be more difficult to make the same mistake again.

Regards!