linux-kernel - Re: [PATCH] staging: media: max96712: fix kernel oops when removing module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <g4df3ogdx7ymhluac2otwxxk2f2kx3o5ih5lqj525xowgxxlfw@a6cpyvfjvspe>
Date: Tue, 17 Dec 2024 08:36:18 +0200
From: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc: Niklas Söderlund <niklas.soderlund@...natech.se>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, 
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Subject: Re: [PATCH] staging: media: max96712: fix kernel oops when removing
 module

Hi,

On Mon, Dec 16, 2024 at 06:05:51PM +0100, Ricardo Ribalda Delgado wrote:
> Hi
> 
> You probably want to add:
> diff --git a/drivers/staging/media/max96712/max96712.c
> b/drivers/staging/media/max96712/max96712.c
> index ede02e8c891c..a47f18d57325 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -418,7 +418,6 @@ static int max96712_probe(struct i2c_client *client)
>         priv->info = of_device_get_match_data(&client->dev);
> 
>         priv->client = client;
> -       i2c_set_clientdata(client, priv);
> 
>         priv->regmap = devm_regmap_init_i2c(client, &max96712_i2c_regmap);
>         if (IS_ERR(priv->regmap))
> 
> That way it will be more difficult to make the same mistake again.

Sounds good. Will fix in v2.

Thanks,
Laurentiu

> 
> Regards!