linux-kernel - Re: [PATCH 5/9] i2c: riic: Make use of devres helper to request deasserted reset line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8snQ37-PnUQX4zam8WiPAh3APOpEaMSkOD_xpVxCkhtZg@mail.gmail.com>
Date: Mon, 16 Dec 2024 18:17:07 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Chris Brandt <chris.brandt@...esas.com>, Andi Shyti <andi.shyti@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Wolfram Sang <wsa@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 5/9] i2c: riic: Make use of devres helper to request
 deasserted reset line

Hi Geert,

Thank you for the review.

On Mon, Dec 16, 2024 at 3:56 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, Dec 13, 2024 at 6:58 PM Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Simplify the `riic_i2c_probe()` function by using the
> > `devm_reset_control_get_optional_exclusive_deasserted()` API to request a
> > deasserted reset line. This eliminates the need to manually deassert the
> > reset control and the additional cleanup.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/i2c/busses/i2c-riic.c
> > +++ b/drivers/i2c/busses/i2c-riic.c
> > @@ -447,18 +442,10 @@ static int riic_i2c_probe(struct platform_device *pdev)
> >                 return dev_err_probe(dev, PTR_ERR(riic->clk),
> >                                      "missing controller clock");
> >
> > -       riic->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
> > +       riic->rstc = devm_reset_control_get_optional_exclusive_deasserted(dev, NULL);
> >         if (IS_ERR(riic->rstc))
> >                 return dev_err_probe(dev, PTR_ERR(riic->rstc),
> > -                                    "Error: missing reset ctrl\n");
> > -
> > -       ret = reset_control_deassert(riic->rstc);
> > -       if (ret)
> > -               return ret;
> > -
> > -       ret = devm_add_action_or_reset(dev, riic_reset_control_assert, riic->rstc);
> > -       if (ret)
> > -               return ret;
> > +                                    "Failed to acquire deasserted reset control\n");
>
> "failed", as all other error messages start with a lower-case character.
> Perhaps drop the " control" from the message?
>
Sure, I will update the error message using `failed` and drop the `control`.

Cheers,
Prabhakar