[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<PSAPR06MB494997E9578D2E2E745AC90B893B2@PSAPR06MB4949.apcprd06.prod.outlook.com>
Date: Mon, 16 Dec 2024 03:50:24 +0000
From: Kevin Chen <kevin_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"joel@....id.au" <joel@....id.au>, "andrew@...econstruct.com.au"
<andrew@...econstruct.com.au>, "tglx@...utronix.de" <tglx@...utronix.de>,
"catalin.marinas@....com" <catalin.marinas@....com>, "will@...nel.org"
<will@...nel.org>, "arnd@...db.de" <arnd@...db.de>, "olof@...om.net"
<olof@...om.net>, "quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
"geert+renesas@...der.be" <geert+renesas@...der.be>,
"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
"konradybcio@...nel.org" <konradybcio@...nel.org>,
"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
"johan+linaro@...nel.org" <johan+linaro@...nel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "soc@...ts.linux.dev" <soc@...ts.linux.dev>
Subject: RE: [PATCH v3 1/6] dt-bindings: interrupt-controller: Refine
size/interrupt-cell usage.
Hi,
> > 1. Because size-cells is no need to use 2, modify to 1 for use.
> > 2. Add minItems to 1 for interrupts for intc1.
> > 3. Add 1 interrupt of intc1 example into yaml file.
> > 4. Add intc1 sub-module of uart12 as example using the intc0 and intc1.
> > ---
> > .../aspeed,ast2700-intc.yaml | 60
> +++++++++++++++----
> > 1 file changed, 47 insertions(+), 13 deletions(-)
> >
>
> As with all your patches, repeating since v1 the same comment, so one more
> last time:
>
> Please run scripts/checkpatch.pl and fix reported warnings. Then please run
> 'scripts/checkpatch.pl --strict' and (probably) fix more warnings.
> Some warnings can be ignored, especially from --strict run, but the code here
> looks like it needs a fix. Feel free to get in touch if the warning is not clear.
OK.
I need to wait the Ryan's series of " "Add support for AST2700 clk driver"" for clk and reset drivers.
I will wait for his commits to be merged with the warnings fixed.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists