linux-kernel - RE: [PATCH v3 5/6] arm64: dts: aspeed: Add initial AST2700 EVB device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PSAPR06MB4949384985104E0CFFB5234B893B2@PSAPR06MB4949.apcprd06.prod.outlook.com>
Date: Mon, 16 Dec 2024 03:58:21 +0000
From: Kevin Chen <kevin_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "joel@....id.au"
	<joel@....id.au>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"catalin.marinas@....com" <catalin.marinas@....com>, "will@...nel.org"
	<will@...nel.org>, "arnd@...db.de" <arnd@...db.de>, "olof@...om.net"
	<olof@...om.net>, "quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
	"geert+renesas@...der.be" <geert+renesas@...der.be>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
	"konradybcio@...nel.org" <konradybcio@...nel.org>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
	"johan+linaro@...nel.org" <johan+linaro@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "soc@...ts.linux.dev" <soc@...ts.linux.dev>
Subject: RE: [PATCH v3 5/6] arm64: dts: aspeed: Add initial AST2700 EVB device
 tree

Hi Krzk,

> > Add EVB board of AST2700 in ASPEED Architecture.
> >
> > Signed-off-by: Kevin Chen <kevin_chen@...eedtech.com>
> > ---
> >  arch/arm64/boot/dts/aspeed/Makefile        |  4 ++
> >  arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 57
> > ++++++++++++++++++++++
> >  2 files changed, 61 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/aspeed/Makefile
> >  create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> >
> > diff --git a/arch/arm64/boot/dts/aspeed/Makefile
> > b/arch/arm64/boot/dts/aspeed/Makefile
> > new file mode 100644
> > index 000000000000..ffe7e15017cc
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/aspeed/Makefile
> > @@ -0,0 +1,4 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +dtb-$(CONFIG_ARCH_ASPEED) += \
> > +	ast2700-evb.dtb
> > diff --git a/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > new file mode 100644
> > index 000000000000..6dad88c98ce0
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +
> > +/dts-v1/;
> > +
> > +#include "aspeed-g7.dtsi"
> > +#include <dt-bindings/gpio/aspeed-gpio.h>
> > +
> > +/ {
> > +	model = "AST2700A1-EVB";
> > +	compatible = "aspeed,ast2700-evb", "aspeed,ast2700";
> > +
> > +	aliases {
> > +		serial12 = &uart12;
> > +	};
> > +
> > +	chosen {
> > +		bootargs = "console=ttyS12,115200n8";
> > +		stdout-path = &uart12;
> 
> Nothing improved. You keep ignoring my comments: not responding, not
> addressing, not fixing the code.
OK. I will remove the bootargs.

> 
> > +	};
> > +
> > +	firmware {
> > +		optee: optee {
> > +			compatible = "linaro,optee-tz";
> > +			method = "smc";
> > +		};
> > +	};
> > +
> > +	memory@...000000 {
> > +		device_type = "memory";
> > +		reg = <0x4 0x00000000 0x40000000>;
> > +	};
> > +
> > +	reserved-memory {
> > +		#address-cells = <2>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		mcu_fw: mcu-firmware@...e00000 {
> > +			reg = <0x4 0x2fe00000 0x200000>;
> > +			no-map;
> > +		};
> > +
> > +		atf: trusted-firmware-a@...000000 {
> > +			reg = <0x4 0x30000000 0x80000>;
> > +			no-map;
> > +		};
> > +
> > +		optee_core: optee_core@...080000 {
> 
> Follow DTS Coding style document. That's the same comment as before.
OK. I will fix to optee-core:optee-core@...080000 {

> 
> 
> Best regards,
> Krzysztof