linux-kernel - Re: [PATCH next 2/2] octeontx2-pf: fix error handling of devlink port in rvu_rep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d045f461-c60a-4653-9a89-81eafe2b12f8@intel.com>
Date: Mon, 16 Dec 2024 09:13:16 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
CC: <dan.carpenter@...aro.org>, <kernel-janitors@...r.kernel.org>,
	<error27@...il.com>, Sunil Goutham <sgoutham@...vell.com>, Geetha sowjanya
	<gakula@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>, hariprasad
	<hkelam@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next 2/2] octeontx2-pf: fix error handling of devlink port
 in rvu_rep_create()

On 12/16/24 08:05, Harshit Mogalapalli wrote:
> Unregister the devlink port when register_netdev() fails.
> 
> Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>

same comment that this is better applied to -net, otherwise fine for me:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

> ---
> This is from static analysis, only compile tested.
> ---
>   drivers/net/ethernet/marvell/octeontx2/nic/rep.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> index 9e3fcbae5dee..04e08e06f30f 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> @@ -690,6 +690,7 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
>   		if (err) {
>   			NL_SET_ERR_MSG_MOD(extack,
>   					   "PFVF representor registration failed");
> +			rvu_rep_devlink_port_unregister(rep);
>   			free_netdev(ndev);
>   			goto exit;
>   		}